networkmanager: remove unused libsoup_2_4 dependency#395311
Merged
Merged
Conversation
Contributor
Author
|
Related: #395063 (comment) |
This comment was marked as resolved.
This comment was marked as resolved.
The libsoup dependency was replaced by curl upstream in the 1.8 release [1]. In adec41e [2] the nix package was updated. However, the libsoup dependency was never dropped and is now unused. This does the drop, after 8 years of it not being used. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/40ddff9cc9f8957ad5c66907c77640f7fccca9ab/NEWS#L1245 [2] NixOS@adec41e
LordGrimmauld
force-pushed
the
nm-libsoup-drop
branch
from
6d5d9d2 to
3609928
Compare
Contributor
Author
|
fixed |
github-actions
Bot
added
10.rebuild-darwin: 0
|
Contributor
Author
|
the broken packages are broken on master too it seems. None of the breaks are related to libsoup and the sierra-breeze has an open PR to fix currently, iirc. This should be fine. |
Member
|
Thanks! |
This was referenced Apr 2, 2025
gupnp-igd: 1.2.0 → 1.6.0; gupnp-igd: refactor; libnice: refactor and switch to gupnp-igd_1_6
#395063
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libsoup dependency was replaced by curl upstream in the 1.8 release [1]. In adec41e [2] the nix package was updated. However, the libsoup dependency was never dropped and is now unused. This does the drop, after 8 years of it not being used.
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/40ddff9cc9f8957ad5c66907c77640f7fccca9ab/NEWS#L1245
[2] adec41e
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.